From all the stories I've heard and research literature I've seen, my own personal, non-medical opinion is this: stay away from a surgeon's knife unless you are absolutely, positively sure you have done everything you can to avoid it.
I don't mean to suggest that hip surgeries (arthroscopy or total hip replacement) never work. Sometimes they DO work and relieve someone's pain. But that doesn't mean they ALWAYS work (they don't), and that doesn't mean surgery works for the reason surgeons claim.
Listen to this podcast on Why Hip Surgery Works: https://youtu.be/LpkoW9qmZ5A
Watch this video about when I think total hip replacement makes sense: https://youtu.be/vtu8a97D4dw
Read this article: Why you DON’T Need Orthopedic Surgery for Joint Pain
Watch this video about Hip Surgery vs. Physical Therapy for FAI: https://youtu.be/OGpEWgk1YGg
Hip Arthroscopy Success Rates for Hip Impingement: https://youtu.be/aXmq7xyUzaQ